feat: create globalConfig from app.manifest#1669
Merged
hetangmodi-crest merged 7 commits intodevelopfrom Mar 31, 2025
Merged
Conversation
9 tasks
hetangmodi-crest
force-pushed
the
feature/create-minimal-gc
branch
from
277e2ed to
0bc7233
Compare
artemrys
requested changes
Mar 31, 2025
...d_addons/expected_output_no_global_config/Splunk_TA_UCCExample/appserver/static/openapi.json
Show resolved
Hide resolved
Member
There was a problem hiding this comment.
Comment for other folks reviewing - the diff is much better if you use "Unified" diff view and hide whitespaces.
hetangmodi-crest
force-pushed
the
feature/create-minimal-gc
branch
from
8641387 to
ad35e23
Compare
artemrys
approved these changes
Mar 31, 2025
Code Coverage 🎉
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: ADDON-78488
PR Type
What kind of change does this PR introduce?
Summary
Changes
Going forward, if the globalConfig doesn't exist in the source directory of an add-on, the UCC framework would create one in the source directory and then proceed with processing of the build process.
User experience
Users using UCC framework for .conf-only TAs would now see a globalConfig.json created in their source code / source directory when they run the
ucc-gen build --source ...command.Checklist
If an item doesn't apply to your changes, leave it unchecked.
Review
Tests
See the testing doc.
Demo/meeting:
Reviewers are encouraged to request meetings or demos if any part of the change is unclear